Implement Gherkin scenarios for UUID and UUri serialization #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit tests for verifying UUID and UUri serialization have been refactired into Cucumber based integration tests that implement the corresponding Gherkin based UUID and UUri scenarios from up-spec.
|
@AnotherDaniel would you mind taking a look? |
AnotherDaniel
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
This is very cool - I will have to take some quality time soon to wrap my head around this Gherkin/Cucumber stuff, but as far as I can tell this looks good!
One minor comment: as we move ahead and create more of these kinds of tests, it might be useful to have all the helper functions (value_as_*(), trimhex()) separated out onto test module level maybe?
AnotherDaniel
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests for verifying UUID and UUri serialization have been
refactored into Cucumber based integration tests that implement the
corresponding Gherkin based UUID and UUri scenarios from up-spec.